avernois/pay_what_you_want
1
0
Fork 0
Code Issues 8 Pull requests 5 Projects Releases Packages Wiki Activity Actions

Proper await for server stop #1

New issue
Closed
opened 2018-06-28 09:14:41 +00:00 by avernois · 7 comments
avernois commented 2018-06-28 09:14:41 +00:00 (Migrated from gitlab.com)
Copy link

To be able to properly test the server, it needs to be stopped/restarted between each test.
But, there is currently no way to know when the server is properly stop (from Spark).

Currently, I use a awfull Thread.sleep. This is not good. (as it might not be enough sometimes).

To be able to properly test the server, it needs to be stopped/restarted between each test. But, there is currently no way to know when the server is properly stop (from Spark). Currently, I use a awfull Thread.sleep. This is not good. (as it might not be enough sometimes).
avernois commented 2018-06-28 09:15:48 +00:00 (Migrated from gitlab.com)
Copy link

It seems that an awaitStop() method made its way into Spark.
But not released yet : https://github.com/perwendel/spark/pull/730/

It seems that an awaitStop() method made its way into Spark. But not released yet : https://github.com/perwendel/spark/pull/730/
avernois commented 2019-02-21 09:17:06 +00:00 (Migrated from gitlab.com)
Copy link

mentioned in merge request !39

mentioned in merge request !39
avernois commented 2019-02-21 09:17:06 +00:00 (Migrated from gitlab.com)
Copy link

created merge request !39 to address this issue

created merge request !39 to address this issue
avernois commented 2019-02-21 09:38:47 +00:00 (Migrated from gitlab.com)
Copy link

mentioned in commit 4d73631547

mentioned in commit 4d73631547f27c19dc29e4cb44e407242187e0d5
avernois commented 2019-02-21 10:34:04 +00:00 (Migrated from gitlab.com)
Copy link

mentioned in commit 2a4c620cbc

mentioned in commit 2a4c620cbcc40d745417aced9e9cf860575e1e88
avernois commented 2019-02-21 10:34:05 +00:00 (Migrated from gitlab.com)
Copy link

closed via merge request !39

closed via merge request !39
avernois commented 2019-02-21 10:34:05 +00:00 (Migrated from gitlab.com)
Copy link

closed via commit 4d73631547

closed via commit 4d73631547f27c19dc29e4cb44e407242187e0d5
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
develop
list_products
latest
release-1.3
14_persistence
16-server-should-return-parsable-exceptions
6-list-product-status
bis-success-and-cancel-url-could-be-set-per-request
rename-below-minimum-amount
10-success-and-cancel-url-could-be-set-per-request
release-1.2
5-remove-a-product_using-a-service
authorization_service
5-remove-a-product
5-remove-a-product_using_authorizer
add_readme
release-1.1
remove_remove_product_feature
4-add-a-way-to-redirect-to-a-specific-page-when-there-is-an-unknow-exception
2-manage-cors
1-proper-await-for-server-stop
release-1.0
type_limited_and_unlimited_product
v1.3
v1.2
v1.1
v1.0
Labels
Clear labels   
Doing

   
To Do

   
api

   
test
No labels
Doing
To Do
api
test
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
avernois/pay_what_you_want#1
No description provided.