avernois/clocks
1
0
Fork 0
Code Issues 8 Pull requests 4 Projects Releases 2 Packages Wiki Activity Actions

Resolve "Configure ntp and timezone servers" #47

Merged
avernois merged 4 commits from 4-configure-ntp-and-timezone-servers into main 2020-08-27 08:42:46 +00:00
Conversation 24 Commits 4 Files changed 12 +366 -151
avernois commented 2020-08-21 20:46:34 +00:00 (Migrated from gitlab.com)
Copy link

Closes #4

Closes #4
avernois commented 2020-08-22 12:10:29 +00:00 (Migrated from gitlab.com)
Copy link

added 1 commit

  • cffe63fa - BaseClock: move clockName into a ConfigParams object

Compare with previous version

added 1 commit <ul><li>cffe63fa - BaseClock: move clockName into a ConfigParams object</li></ul> [Compare with previous version](/avernois/clocks/-/merge_requests/26/diffs?diff_id=107795023&start_sha=6b2035203509d7fa0718ea298095b689a101ffec)
avernois commented 2020-08-22 12:51:54 +00:00 (Migrated from gitlab.com)
Copy link

added 1 commit

  • de302a53 - BaseClock: move clockName into a ConfigParams object

Compare with previous version

added 1 commit <ul><li>de302a53 - BaseClock: move clockName into a ConfigParams object</li></ul> [Compare with previous version](/avernois/clocks/-/merge_requests/26/diffs?diff_id=107796554&start_sha=cffe63fa33208010ed728fb70a92203570ce0c22)
avernois commented 2020-08-22 14:01:00 +00:00 (Migrated from gitlab.com)
Copy link

added 1 commit

  • 14ff3ea1 - BaseClock: move clockName into a ConfigParams object

Compare with previous version

added 1 commit <ul><li>14ff3ea1 - BaseClock: move clockName into a ConfigParams object</li></ul> [Compare with previous version](/avernois/clocks/-/merge_requests/26/diffs?diff_id=107799036&start_sha=de302a5343f16a31a2ac281bf7e668acae30fa02)
avernois commented 2020-08-22 16:42:32 +00:00 (Migrated from gitlab.com)
Copy link

added 1 commit

  • 74bc84ab - BaseClock: move time related operation in Clock

Compare with previous version

added 1 commit <ul><li>74bc84ab - BaseClock: move time related operation in Clock</li></ul> [Compare with previous version](/avernois/clocks/-/merge_requests/26/diffs?diff_id=107804561&start_sha=14ff3ea1146b92d8785242a89478362ca3f1ceb7)
avernois commented 2020-08-22 17:36:04 +00:00 (Migrated from gitlab.com)
Copy link

added 3 commits

  • 9469f96f - BaseClock: move clockName into a ConfigParams object
  • 5427df5f - BaseClock: move time related operation in Clock
  • 5f3389ee - BaseClock: more network name (hostname, mdns) into NetworkClockId

Compare with previous version

added 3 commits <ul><li>9469f96f - BaseClock: move clockName into a ConfigParams object</li><li>5427df5f - BaseClock: move time related operation in Clock</li><li>5f3389ee - BaseClock: more network name (hostname, mdns) into NetworkClockId</li></ul> [Compare with previous version](/avernois/clocks/-/merge_requests/26/diffs?diff_id=107806258&start_sha=74bc84ab049c04638e67fecd508ca2e2e1c6e3fa)
avernois commented 2020-08-22 17:36:24 +00:00 (Migrated from gitlab.com)
Copy link

added 1 commit

  • 4e605d45 - WIP: config server

Compare with previous version

added 1 commit <ul><li>4e605d45 - WIP: config server</li></ul> [Compare with previous version](/avernois/clocks/-/merge_requests/26/diffs?diff_id=107806266&start_sha=5f3389ee28e8cdaf0c74db184f277b5dd60304e9)
avernois commented 2020-08-22 19:57:41 +00:00 (Migrated from gitlab.com)
Copy link

added 4 commits

  • 9348a010 - BaseClock: move clockName into a ClockConfig object
  • f934804c - BaseClock: move time related operation in Clock
  • aa462d19 - BaseClock: more network name (hostname, mdns) into NetworkClockId
  • 2351db5b - WIP: config server

Compare with previous version

added 4 commits <ul><li>9348a010 - BaseClock: move clockName into a ClockConfig object</li><li>f934804c - BaseClock: move time related operation in Clock</li><li>aa462d19 - BaseClock: more network name (hostname, mdns) into NetworkClockId</li><li>2351db5b - WIP: config server</li></ul> [Compare with previous version](/avernois/clocks/-/merge_requests/26/diffs?diff_id=107813223&start_sha=4e605d4593d8094e6999b7216c6bf3dba66be2fc)
avernois commented 2020-08-23 10:19:09 +00:00 (Migrated from gitlab.com)
Copy link

added 1 commit

  • 8138a282 - wip: configure ntpPool

Compare with previous version

added 1 commit <ul><li>8138a282 - wip: configure ntpPool</li></ul> [Compare with previous version](/avernois/clocks/-/merge_requests/26/diffs?diff_id=107851818&start_sha=2351db5ba1a2259f23fc1b7f5a1cc0efb089632d)
avernois commented 2020-08-23 13:58:43 +00:00 (Migrated from gitlab.com)
Copy link

added 1 commit

  • ddb38fb3 - BaseClock: add a way to configure NTPPool

Compare with previous version

added 1 commit <ul><li>ddb38fb3 - BaseClock: add a way to configure NTPPool</li></ul> [Compare with previous version](/avernois/clocks/-/merge_requests/26/diffs?diff_id=107870108&start_sha=8138a282d77967334a568171379d4e03ab2159a1)
avernois commented 2020-08-23 15:10:04 +00:00 (Migrated from gitlab.com)
Copy link

added 1 commit

  • 3572c4ae - ZoneOffset: add a way to configure ZoneTransition host

Compare with previous version

added 1 commit <ul><li>3572c4ae - ZoneOffset: add a way to configure ZoneTransition host</li></ul> [Compare with previous version](/avernois/clocks/-/merge_requests/26/diffs?diff_id=107876071&start_sha=ddb38fb3909e50182460b71f0445881796453acf)
avernois commented 2020-08-23 16:31:09 +00:00 (Migrated from gitlab.com)
Copy link

added 4 commits

  • ff84b662 - BaseClock: move time related operation in Clock
  • 6194c75b - BaseClock: move network name (hostname, mdns) into NetworkClockId
  • 7277ce8f - BaseClock: add a way to configure NTPPool
  • 164740db - ZoneOffset: add a way to configure ZoneTransition host

Compare with previous version

added 4 commits <ul><li>ff84b662 - BaseClock: move time related operation in Clock</li><li>6194c75b - BaseClock: move network name (hostname, mdns) into NetworkClockId</li><li>7277ce8f - BaseClock: add a way to configure NTPPool</li><li>164740db - ZoneOffset: add a way to configure ZoneTransition host</li></ul> [Compare with previous version](/avernois/clocks/-/merge_requests/26/diffs?diff_id=107880506&start_sha=3572c4ae6926a9595bcf109801ccc3d9f9326721)
avernois commented 2020-08-23 16:36:59 +00:00 (Migrated from gitlab.com)
Copy link

unmarked as a Work In Progress

unmarked as a **Work In Progress**
avernois commented 2020-08-23 17:12:26 +00:00 (Migrated from gitlab.com)
Copy link

added 4 commits

  • fecedf5c - BaseClock: move time related operation in Clock
  • caf92519 - BaseClock: move network name (hostname, mdns) into NetworkClockId
  • 486a0161 - BaseClock: add a way to configure NTPPool
  • f917a01c - ZoneOffset: add a way to configure ZoneTransition host

Compare with previous version

added 4 commits <ul><li>fecedf5c - BaseClock: move time related operation in Clock</li><li>caf92519 - BaseClock: move network name (hostname, mdns) into NetworkClockId</li><li>486a0161 - BaseClock: add a way to configure NTPPool</li><li>f917a01c - ZoneOffset: add a way to configure ZoneTransition host</li></ul> [Compare with previous version](/avernois/clocks/-/merge_requests/26/diffs?diff_id=107884086&start_sha=164740db957ec8bbe0daba0ea5003a0dba4fed2c)
avernois commented 2020-08-24 21:05:09 +00:00 (Migrated from gitlab.com)
Copy link

that method is not used

that method is not used
avernois commented 2020-08-24 21:10:08 +00:00 (Migrated from gitlab.com)
Copy link

Serial.println.
Maybe i need some kind of DEBUG directive for that kind of info.

Serial.println. Maybe i need some kind of DEBUG directive for that kind of info.
avernois commented 2020-08-24 21:10:53 +00:00 (Migrated from gitlab.com)
Copy link

If I rework the file, I might clean the spacing while I'm at it :)

If I rework the file, I might clean the spacing while I'm at it :)
avernois commented 2020-08-24 21:14:12 +00:00 (Migrated from gitlab.com)
Copy link

if MDNS.begin failed, MDNS.addService is kind of pointless ;)

if MDNS.begin failed, MDNS.addService is kind of pointless ;)
avernois commented 2020-08-24 21:18:03 +00:00 (Migrated from gitlab.com)
Copy link

#define in other .h are using _ between words. WIFI_LED_CLOCK_H

#define in other .h are using _ between words. __WIFI_LED_CLOCK_H__
avernois commented 2020-08-27 08:33:08 +00:00 (Migrated from gitlab.com)
Copy link

changed this line in version 13 of the diff

changed this line in [version 13 of the diff](/avernois/clocks/-/merge_requests/26/diffs?diff_id=108647988&start_sha=f917a01c4cd6b148ea0ebbc3fbefa850cfc44e0c#efcf854a01a89a8f2ec1768401127a3736eafe1b_4_3)
avernois commented 2020-08-27 08:33:08 +00:00 (Migrated from gitlab.com)
Copy link

changed this line in version 13 of the diff

changed this line in [version 13 of the diff](/avernois/clocks/-/merge_requests/26/diffs?diff_id=108647988&start_sha=f917a01c4cd6b148ea0ebbc3fbefa850cfc44e0c#efcf854a01a89a8f2ec1768401127a3736eafe1b_16_11)
avernois commented 2020-08-27 08:33:08 +00:00 (Migrated from gitlab.com)
Copy link

changed this line in version 13 of the diff

changed this line in [version 13 of the diff](/avernois/clocks/-/merge_requests/26/diffs?diff_id=108647988&start_sha=f917a01c4cd6b148ea0ebbc3fbefa850cfc44e0c#f6f09c7f2a108ad58c202049213d0ea75b5bac99_13_14)
avernois commented 2020-08-27 08:33:08 +00:00 (Migrated from gitlab.com)
Copy link

changed this line in version 13 of the diff

changed this line in [version 13 of the diff](/avernois/clocks/-/merge_requests/26/diffs?diff_id=108647988&start_sha=f917a01c4cd6b148ea0ebbc3fbefa850cfc44e0c#50f2bdf90b7b043e406f56658882e81e8a642943_1_1)
avernois commented 2020-08-27 08:33:09 +00:00 (Migrated from gitlab.com)
Copy link

added 4 commits

  • 20c7a57a - BaseClock: move time related operation in Clock
  • 8e7b3df6 - BaseClock: move network name (hostname, mdns) into NetworkClockId
  • d1cb83f5 - BaseClock: add a way to configure NTPPool
  • 7eca1582 - ZoneOffset: add a way to configure ZoneTransition host

Compare with previous version

added 4 commits <ul><li>20c7a57a - BaseClock: move time related operation in Clock</li><li>8e7b3df6 - BaseClock: move network name (hostname, mdns) into NetworkClockId</li><li>d1cb83f5 - BaseClock: add a way to configure NTPPool</li><li>7eca1582 - ZoneOffset: add a way to configure ZoneTransition host</li></ul> [Compare with previous version](/avernois/clocks/-/merge_requests/26/diffs?diff_id=108647988&start_sha=f917a01c4cd6b148ea0ebbc3fbefa850cfc44e0c)
avernois commented 2020-08-27 08:42:38 +00:00 (Migrated from gitlab.com)
Copy link

resolved all threads

resolved all threads
avernois (Migrated from gitlab.com) merged commit into main 2020-08-27 08:42:47 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
common

   
config

   
defect

   
idea

   
linear

   
square
No labels
common
config
defect
idea
linear
square
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
avernois/clocks!47
No description provided.