avernois/clocks
1
0
Fork 0
Code Issues 8 Pull requests 4 Projects Releases 2 Packages Wiki Activity Actions

WIP: Draft: Refactor led clock display #53

Closed
avernois wants to merge 0 commits from refactor_LedClockDisplay into main
pull from: refactor_LedClockDisplay
merge into: avernois:main
Conversation 23 Commits - Files changed -
avernois commented 2020-11-13 17:30:22 +00:00 (Migrated from gitlab.com)
Copy link

The goal is to simplifies LedClockDisplay and introduces 'Frame' as a way to represent what can be displayed.

Changes need to be propagated to all Clocks before this can be merged:

  • 4_leds
  • acrylic word clock
  • gouge
  • linear
  • round
  • square
  • triangle
The goal is to simplifies LedClockDisplay and introduces 'Frame' as a way to represent what can be displayed. Changes need to be propagated to all Clocks before this can be merged: - [x] 4_leds - [x] acrylic word clock - [x] gouge - [x] linear - [x] round - [x] square - [x] triangle
avernois commented 2020-11-13 17:32:32 +00:00 (Migrated from gitlab.com)
Copy link

added 2 commits

  • 5ea4361a - BaseClock: time representation are now defined inside a specific frame
  • 94d39bd6 - 4_leds: implements new Frame way of representing time

Compare with previous version

added 2 commits <ul><li>5ea4361a - BaseClock: time representation are now defined inside a specific frame</li><li>94d39bd6 - 4_leds: implements new Frame way of representing time</li></ul> [Compare with previous version](/avernois/clocks/-/merge_requests/32/diffs?diff_id=124464388&start_sha=c499706909cdf0361b8c6a433f27fcdca83f61cf)
avernois commented 2020-11-13 17:43:51 +00:00 (Migrated from gitlab.com)
Copy link

mentioned in merge request !44

mentioned in merge request !44
avernois commented 2020-11-13 17:45:48 +00:00 (Migrated from gitlab.com)
Copy link

changed the description

changed the description
avernois commented 2020-11-13 17:45:53 +00:00 (Migrated from gitlab.com)
Copy link

marked the checklist item 4_leds as completed

marked the checklist item **4_leds** as completed
avernois commented 2020-11-13 18:22:12 +00:00 (Migrated from gitlab.com)
Copy link

added 2 commits

  • 8ba1fa2c - acrylic wordclock: implements new Frame way of representing time
  • 30ac5329 - gouge: implements new Frame way of representing time

Compare with previous version

added 2 commits <ul><li>8ba1fa2c - acrylic wordclock: implements new Frame way of representing time</li><li>30ac5329 - gouge: implements new Frame way of representing time</li></ul> [Compare with previous version](/avernois/clocks/-/merge_requests/32/diffs?diff_id=124471994&start_sha=94d39bd6825eb137bb79a400fe5a0406c99e852d)
avernois commented 2020-11-13 18:40:26 +00:00 (Migrated from gitlab.com)
Copy link

While nice and fun, the use of "Frame" as a template does not allow the dynamic change of how the time is represented ("square" as an example).

While nice and fun, the use of "Frame" as a template does not allow the dynamic change of how the time is represented ("square" as an example).
avernois commented 2020-11-13 22:54:13 +00:00 (Migrated from gitlab.com)
Copy link

added 2 commits

  • 3a09ff12 - BaseClock: time representation are now defined inside a specific frame
  • 5d809383 - 4_leds: implements as a ClockFace

Compare with previous version

added 2 commits <ul><li>3a09ff12 - BaseClock: time representation are now defined inside a specific frame</li><li>5d809383 - 4_leds: implements as a ClockFace</li></ul> [Compare with previous version](/avernois/clocks/-/merge_requests/32/diffs?diff_id=124501656&start_sha=30ac5329eaf38e27c9716f55f3a92a149b8c03e3)
avernois commented 2020-11-13 23:21:02 +00:00 (Migrated from gitlab.com)
Copy link

added 2 commits

  • 293004f0 - BaseClock: time representation are now defined inside a specific frame
  • c82f1223 - 4_leds: implements as a ClockFace

Compare with previous version

added 2 commits <ul><li>293004f0 - BaseClock: time representation are now defined inside a specific frame</li><li>c82f1223 - 4_leds: implements as a ClockFace</li></ul> [Compare with previous version](/avernois/clocks/-/merge_requests/32/diffs?diff_id=124503547&start_sha=5d809383ebc71d82eb6d4b85c34bac844f093863)
avernois commented 2020-11-14 11:34:43 +00:00 (Migrated from gitlab.com)
Copy link

I don't like that allocation here.
I'd prefer if the allocation was made at the same level as the destruction (currently in WifiLedClock)

I don't like that allocation here. I'd prefer if the allocation was made at the same level as the destruction (currently in WifiLedClock)
avernois commented 2020-11-14 12:16:46 +00:00 (Migrated from gitlab.com)
Copy link

changed this line in version 6 of the diff

changed this line in [version 6 of the diff](/avernois/clocks/-/merge_requests/32/diffs?diff_id=124528286&start_sha=c82f1223f3750c8cd60b7db08c817d499cb95d1a#72a1a35df21aeb95dd32920a2ea4decf9df7dd48_13_12)
avernois commented 2020-11-14 12:16:46 +00:00 (Migrated from gitlab.com)
Copy link

added 2 commits

  • b0f80233 - BaseClock: time representation are now defined inside a specific frame
  • d0f0f020 - 4_leds: implements as a ClockFace

Compare with previous version

added 2 commits <ul><li>b0f80233 - BaseClock: time representation are now defined inside a specific frame</li><li>d0f0f020 - 4_leds: implements as a ClockFace</li></ul> [Compare with previous version](/avernois/clocks/-/merge_requests/32/diffs?diff_id=124528286&start_sha=c82f1223f3750c8cd60b7db08c817d499cb95d1a)
avernois commented 2020-11-14 12:18:40 +00:00 (Migrated from gitlab.com)
Copy link

resolved all threads

resolved all threads
avernois commented 2020-11-14 12:18:43 +00:00 (Migrated from gitlab.com)
Copy link

Well, we don't need a Frame*, a Frame is enough and let the system take care of destruction.

Well, we don't need a Frame*, a Frame is enough and let the system take care of destruction.
avernois commented 2020-11-14 15:50:15 +00:00 (Migrated from gitlab.com)
Copy link

added 3 commits

  • 08fa0ad8 - BaseClock: time representation are now defined inside a specific frame
  • 16d48b9c - 4_leds: implements as a ClockFace
  • db224be9 - square: implements as a ClockFace

Compare with previous version

added 3 commits <ul><li>08fa0ad8 - BaseClock: time representation are now defined inside a specific frame</li><li>16d48b9c - 4_leds: implements as a ClockFace</li><li>db224be9 - square: implements as a ClockFace</li></ul> [Compare with previous version](/avernois/clocks/-/merge_requests/32/diffs?diff_id=124536325&start_sha=d0f0f0202b8a0bde2c2f3332aba88c44fa742f19)
avernois commented 2020-11-14 16:28:53 +00:00 (Migrated from gitlab.com)
Copy link

added 2 commits

  • f9d3d4e5 - linear: implements as a ClockFace
  • 569e808b - acrylic wordclock: implements as a ClockFace

Compare with previous version

added 2 commits <ul><li>f9d3d4e5 - linear: implements as a ClockFace</li><li>569e808b - acrylic wordclock: implements as a ClockFace</li></ul> [Compare with previous version](/avernois/clocks/-/merge_requests/32/diffs?diff_id=124538419&start_sha=db224be91046dd20c9620441ec03e43ae4554acc)
avernois commented 2020-11-14 18:04:13 +00:00 (Migrated from gitlab.com)
Copy link

added 7 commits

  • d2b2dbcb - 4_leds: refactor as a ClockFace
  • 8ff6bef5 - square: refactor as a ClockFace
  • 70ab1500 - linear: refactor as a ClockFace
  • ac58c8bf - acrylic wordclock: refactor as a ClockFace
  • ca395ab4 - gouge: refactor as a ClockFace
  • c8f8d3a6 - triangle: refactor as a ClockFace
  • 8c5f30ac - round: refactor as a ClockFace

Compare with previous version

added 7 commits <ul><li>d2b2dbcb - 4_leds: refactor as a ClockFace</li><li>8ff6bef5 - square: refactor as a ClockFace</li><li>70ab1500 - linear: refactor as a ClockFace</li><li>ac58c8bf - acrylic wordclock: refactor as a ClockFace</li><li>ca395ab4 - gouge: refactor as a ClockFace</li><li>c8f8d3a6 - triangle: refactor as a ClockFace</li><li>8c5f30ac - round: refactor as a ClockFace</li></ul> [Compare with previous version](/avernois/clocks/-/merge_requests/32/diffs?diff_id=124542281&start_sha=569e808bcea4c4aecd8f63cb5ca4740fbc38953b)
avernois commented 2020-11-19 08:05:58 +00:00 (Migrated from gitlab.com)
Copy link

marked the checklist item round as completed

marked the checklist item **round** as completed
avernois commented 2020-11-19 08:06:03 +00:00 (Migrated from gitlab.com)
Copy link

marked the checklist item triangle as completed

marked the checklist item **triangle** as completed
avernois commented 2020-11-19 08:06:08 +00:00 (Migrated from gitlab.com)
Copy link

marked the checklist item gouge as completed

marked the checklist item **gouge** as completed
avernois commented 2020-11-19 08:06:15 +00:00 (Migrated from gitlab.com)
Copy link

marked the checklist item acrylic word clock as completed

marked the checklist item **acrylic word clock** as completed
avernois commented 2020-11-19 08:06:21 +00:00 (Migrated from gitlab.com)
Copy link

marked the checklist item square as completed

marked the checklist item **square** as completed
avernois commented 2020-11-19 08:06:27 +00:00 (Migrated from gitlab.com)
Copy link

marked the checklist item linear as completed

marked the checklist item **linear** as completed
avernois commented 2020-12-08 14:50:31 +00:00 (Migrated from gitlab.com)
Copy link

This refactoring is a preparation work for #7 and will be integrated in the same mr.

This refactoring is a preparation work for #7 and will be integrated in the same mr.
avernois (Migrated from gitlab.com) closed this pull request 2020-12-08 14:50:31 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
common

   
config

   
defect

   
idea

   
linear

   
square
No labels
common
config
defect
idea
linear
square
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
avernois/clocks!53
No description provided.