WIP: Resolve "Remove a product" #46

Draft

avernois wants to merge 9 commits from 5-remove-a-product into develop

pull from: 5-remove-a-product

merge into: avernois:develop

avernois:develop

avernois:list_products

avernois:latest

avernois:release-1.3

avernois:14_persistence

avernois:16-server-should-return-parsable-exceptions

avernois:6-list-product-status

avernois:bis-success-and-cancel-url-could-be-set-per-request

avernois:rename-below-minimum-amount

avernois:10-success-and-cancel-url-could-be-set-per-request

avernois:release-1.2

avernois:5-remove-a-product_using-a-service

avernois:authorization_service

avernois:5-remove-a-product_using_authorizer

avernois:add_readme

avernois:release-1.1

avernois:remove_remove_product_feature

avernois:4-add-a-way-to-redirect-to-a-specific-page-when-there-is-an-unknow-exception

avernois:2-manage-cors

avernois:1-proper-await-for-server-stop

avernois:release-1.0

avernois:type_limited_and_unlimited_product

Conversation 12 Commits 9 Files changed 17 +250 -16

avernois commented 2019-04-25 08:10:17 +00:00 (Migrated from gitlab.com)

Copy link

Closes #5

Closes #5

avernois commented 2019-04-25 08:10:18 +00:00 (Migrated from gitlab.com)

Copy link

restored source branch 5-remove-a-product

restored source branch `5-remove-a-product`

avernois commented 2019-04-25 08:51:34 +00:00 (Migrated from gitlab.com)

Copy link

added 1 commit

• 40dd9b24 - wip: add StopSellOfAProduct action

Compare with previous version

added 1 commit <ul><li>40dd9b24 - wip: add StopSellOfAProduct action</li></ul> [Compare with previous version](https://gitlab.com/avernois/pay_what_you_want-stripe/merge_requests/29/diffs?diff_id=40331001&start_sha=bb9f84fa49352fbe17973d5fc3329d9a7a6693e3)

avernois commented 2019-04-25 09:20:46 +00:00 (Migrated from gitlab.com)

Copy link

added 1 commit

• 7356ea34 - wip: add emptyStock to productService

Compare with previous version

added 1 commit <ul><li>7356ea34 - wip: add emptyStock to productService</li></ul> [Compare with previous version](https://gitlab.com/avernois/pay_what_you_want-stripe/merge_requests/29/diffs?diff_id=40334248&start_sha=40dd9b244268cd763c91adc5aac708279d8e616b)

avernois commented 2019-04-25 09:57:02 +00:00 (Migrated from gitlab.com)

Copy link

added 1 commit

• 9865506b - wip: implement /stop/:productname endpoint

Compare with previous version

added 1 commit <ul><li>9865506b - wip: implement /stop/:productname endpoint</li></ul> [Compare with previous version](https://gitlab.com/avernois/pay_what_you_want-stripe/merge_requests/29/diffs?diff_id=40339181&start_sha=7356ea3417d6fca6e3e0d6ee2da53fe67fad15cc)

avernois commented 2019-04-25 12:58:53 +00:00 (Migrated from gitlab.com)

Copy link

added 1 commit

• e4ee6a10 - wip: add authorizerFactory

Compare with previous version

added 1 commit <ul><li>e4ee6a10 - wip: add authorizerFactory</li></ul> [Compare with previous version](https://gitlab.com/avernois/pay_what_you_want-stripe/merge_requests/29/diffs?diff_id=40360390&start_sha=9865506b942779361eeca8a16525c37dfab0f182)

avernois commented 2019-04-25 13:44:29 +00:00 (Migrated from gitlab.com)

Copy link

added 2 commits

• 924ec7d9 - wip: refactor TokenAuthorizer
• fa5a60ef - wip: refactor TokenAuthorizer

Compare with previous version

added 2 commits <ul><li>924ec7d9 - wip: refactor TokenAuthorizer</li><li>fa5a60ef - wip: refactor TokenAuthorizer</li></ul> [Compare with previous version](https://gitlab.com/avernois/pay_what_you_want-stripe/merge_requests/29/diffs?diff_id=40365671&start_sha=e4ee6a10e84113b0bf6639302b358ae8ce3c5054)

avernois commented 2019-04-25 15:21:50 +00:00 (Migrated from gitlab.com)

Copy link

added 1 commit

• 68754fc6 - wip: add a secret token in the api

Compare with previous version

added 1 commit <ul><li>68754fc6 - wip: add a secret token in the api</li></ul> [Compare with previous version](https://gitlab.com/avernois/pay_what_you_want-stripe/merge_requests/29/diffs?diff_id=40376544&start_sha=fa5a60effc73b65ec9386a23494b501840aa8179)

avernois commented 2019-04-25 15:22:34 +00:00 (Migrated from gitlab.com)

Copy link

added 1 commit

• 5627cfee - wip: add a secret token in the api

Compare with previous version

added 1 commit <ul><li>5627cfee - wip: add a secret token in the api</li></ul> [Compare with previous version](https://gitlab.com/avernois/pay_what_you_want-stripe/merge_requests/29/diffs?diff_id=40376624&start_sha=68754fc6f603173e921c1e1aec5baae7042586db)

avernois commented 2019-04-28 12:51:08 +00:00 (Migrated from gitlab.com)

Copy link

added 1 commit

• 184d4595 - wip: Add an AuthorizationService that checks credentials against a secret token

Compare with previous version

added 1 commit <ul><li>184d4595 - wip: Add an AuthorizationService that checks credentials against a secret token</li></ul> [Compare with previous version](https://gitlab.com/avernois/pay_what_you_want-stripe/merge_requests/29/diffs?diff_id=40591409&start_sha=5627cfee1a80f3e3504260783aeb92d64260084f)

avernois commented 2019-04-28 13:06:10 +00:00 (Migrated from gitlab.com)

Copy link

added 1 commit

• 2f4956d8 - wip: improve logging of unauthorized exception

Compare with previous version

added 1 commit <ul><li>2f4956d8 - wip: improve logging of unauthorized exception</li></ul> [Compare with previous version](https://gitlab.com/avernois/pay_what_you_want-stripe/merge_requests/29/diffs?diff_id=40591684&start_sha=184d45953d27b42f8a67a98f814a70a72a61e8ce)

avernois commented 2019-05-02 21:31:08 +00:00 (Migrated from gitlab.com)

Copy link

added 5 commits

• e4ee6a10 - wip: add authorizerFactory
• 924ec7d9 - wip: refactor TokenAuthorizer
• fa5a60ef - wip: refactor TokenAuthorizer
• 5627cfee - wip: add a secret token in the api
• d92a11ed - Wip: done but not really

Compare with previous version

added 5 commits <ul><li>e4ee6a10 - wip: add authorizerFactory</li><li>924ec7d9 - wip: refactor TokenAuthorizer</li><li>fa5a60ef - wip: refactor TokenAuthorizer</li><li>5627cfee - wip: add a secret token in the api</li><li>d92a11ed - Wip: done but not really</li></ul> [Compare with previous version](https://gitlab.com/avernois/pay_what_you_want-stripe/merge_requests/29/diffs?diff_id=40993931&start_sha=2f4956d8b571e236b96cb5227ffe57ede8f128ea)

avernois commented 2019-05-02 21:40:11 +00:00 (Migrated from gitlab.com)

Copy link

This is the code we write during a phoresie session.
If the concept of the authorizer was a nice idea it did not really live up to it.

Pushing the idea we ended up with a design that would allow

   stopSellOfAProduct.stop(new Denied(), productName);

which is not really nice (as the caller can decide wether or not check the authorization)

This is the code we write during a phoresie session. If the concept of the authorizer was a nice idea it did not really live up to it. Pushing the idea we ended up with a design that would allow ``` stopSellOfAProduct.stop(new Denied(), productName); ``` which is not really nice (as the caller can decide wether or not check the authorization)

This pull request has changes conflicting with the target branch.

• pay_what_you_want/pom.xml
• pay_what_you_want/src/main/java/fr/craftinglabs/apps/paywhatyouwant/server/PayWhatYouWantServer.java
• pay_what_you_want/src/main/java/fr/craftinglabs/apps/paywhatyouwant/server/Server.java
• pay_what_you_want/src/test/java/fr/craftinglabs/apps/paywhatyouwant/server/ServerTest.java
• pay_what_you_want_example/pom.xml
• pom.xml

View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Merge commit title Merge pull request 'WIP: Resolve "Remove a product"' (#46) from 5-remove-a-product into develop

Merge commit body Reviewed-on: https://forge.crafting-labs.fr/avernois/pay_what_you_want/pulls/46

Merge pull request 'WIP: Resolve "Remove a product"' (#46) from 5-remove-a-product into develop Reviewed-on: https://forge.crafting-labs.fr/avernois/pay_what_you_want/pulls/46 Copy merge commit message

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin 5-remove-a-product:5-remove-a-product

git switch 5-remove-a-product

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch develop

git merge --no-ff 5-remove-a-product

git switch 5-remove-a-product

git rebase develop

git switch develop

git merge --ff-only 5-remove-a-product

git switch 5-remove-a-product

git rebase develop

git switch develop

git merge --no-ff 5-remove-a-product

git switch develop

git merge --squash 5-remove-a-product

git switch develop

git merge --ff-only 5-remove-a-product

git switch develop

git merge 5-remove-a-product

git push origin develop

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

Doing

  

To Do

  

api

  

test

No labels

Doing

To Do

api

test

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

avernois/pay_what_you_want!46

No description provided.